Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: replace use of erasure with runtimeClass #252

Closed
chuwy opened this issue Jun 20, 2020 · 3 comments
Closed

Common: replace use of erasure with runtimeClass #252

chuwy opened this issue Jun 20, 2020 · 3 comments
Labels
good first issue Good for newcomers
Milestone
1.3.0

Comments

@chuwy
Copy link
Contributor

chuwy commented Jun 20, 2020

Should fix some warnings:

[warn] /vagrant/3-enrich/scala-common-enrich/src/main/scala/com.snowplowanalytics.snowplow.enrich/common/utils/MapTransformer.scala:94: method erasure in trait ClassManifestDeprecatedApis is deprecated: Use runtimeClass instead
[warn]     val newInst = m.erasure.newInstance()
@chuwy
Copy link
Contributor Author

chuwy commented Jun 20, 2020

Migrated from snowplow/snowplow#2050 (comments are auto-generated)

@chuwy chuwy mentioned this issue Jun 20, 2020
Closed
@chuwy
Copy link
Contributor Author

chuwy commented Jun 20, 2020

This will make SCE compiling on JDK 11.

@chuwy chuwy added this to the Simplify codebase milestone Jun 20, 2020
@chuwy chuwy added the good first issue Good for newcomers label Jun 20, 2020
@chuwy chuwy mentioned this issue Jun 29, 2020
Closed
szareiangm added a commit to globeandmail/enrich that referenced this issue Jul 3, 2020
@szareiangm
Common: replace use of erasure with runtimeClass (Closes snowplow#252)
8df198d
@oguzhanunlu
Copy link
Member

Thanks for the PR @szareiangm ! I can confirm Common Enrich compilation error on JDK 11 is fixed thanks to your commit!

oguzhanunlu pushed a commit that referenced this issue Jul 10, 2020
@szareiangm @oguzhanunlu
Common: replace use of erasure with runtimeClass (close #252)
9be4b0b
chuwy pushed a commit that referenced this issue Jul 11, 2020
@szareiangm @chuwy
Common: replace use of erasure with runtimeClass (close #252)
41fc3f6
@chuwy chuwy modified the milestones: Simplify codebase, 1.3.0 Jul 12, 2020
@chuwy chuwy closed this as completed in 56516f4 Jul 14, 2020
@chuwy chuwy mentioned this issue Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
2 participants
@chuwy @oguzhanunlu