Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded limit of exclude versions length #166

Merged

Conversation

rlh1994
Copy link
Contributor

@rlh1994 rlh1994 commented Apr 10, 2024

Description

This PR fixes an issue where the exclude versions was limited to only 1 digit for each part of the version number.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

https://snplow.atlassian.net/browse/PE-6264

Checklist

  • 🎉 I have verified that these changes work in Redshift
  • 💣 Is your change a breaking change?
  • 📖 I have updated the CHANGELOG.md

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 internal package docs (ymls, macros, readme, if applicable)
  • 📕 I have raised a Snowplow documentation PR if applicable (Link here if required)
  • 🙅 no documentation needed

@rlh1994 rlh1994 requested a review from a team as a code owner April 10, 2024 20:33
Copy link
Contributor

@agnessnowplow agnessnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlh1994 rlh1994 merged commit d27a9d9 into release/snowplow-utils/0.16.4 Apr 11, 2024
4 checks passed
@rlh1994 rlh1994 deleted the fix/too-strict-exclude-versions branch April 11, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants