Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add index to unnest and array size macro #156

Merged

Conversation

agnessnowplow
Copy link
Contributor

Description & motivation

This pull request is to support the new marketing attribution package. It adds a new cross-db macro to get the array size and also adds the optional functionality to retrieve the index number (starting from 0) for the unnest() macro. This latter currently only supports Snowflake the rest needs testing/to be added hence it's currently draft pull request.

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@snowplowcla snowplowcla added the cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. label Jan 2, 2024
@agnessnowplow agnessnowplow marked this pull request as ready for review January 10, 2024 11:25
@agnessnowplow agnessnowplow requested a review from a team as a code owner January 10, 2024 11:25
Copy link
Contributor

@rlh1994 rlh1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@rlh1994 rlh1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agnessnowplow agnessnowplow force-pushed the feature/add_index_to_unnest branch from 59cef14 to c9d1912 Compare January 24, 2024 12:20
@agnessnowplow agnessnowplow merged commit a7a5a24 into release/snowplow-utils/0.15.3 Jan 24, 2024
4 checks passed
@agnessnowplow agnessnowplow deleted the feature/add_index_to_unnest branch January 24, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants