Fix counting impressions based using distinct play_id instead of page_view_id (close #72) #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlh1994
approved these changes
Jun 17, 2024
matus-tomlein
force-pushed
the
issue/72-fix_impressions
branch
from
68cdf76 to
e89563b
Compare
matus-tomlein
changed the title
…_view_id (close#72)
matus-tomlein
force-pushed
the
issue/72-fix_impressions
branch
from
e89563b to
131ed72
Compare
matus-tomlein
added a commit
that referenced
this pull request
Jun 20, 2024
…_view_id (close#72) PR #73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #72
Description & motivation
This PR changes how impressions are counted in the media stats table – instead of counting the distinct page views, it counts the distinct play ids (so the player instances). This has the advantage that if more than one video is displayed on the page, the impressions are counted for each video and the subsequent play rate is counted correctly.
This causes a change in the data which might require users to rerun their models, so I think it is a breaking change. To be honest, nobody asked as for this, so we are not under pressure to release this if we have doubts about whether this is what we want or about the breaking change.
Checklist