-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/snowplow media player/0.6.0 #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d mobile (close #49) Minor changes based on review Use snowplow_utils.get_field macro from the field macro Correct table aliases in macro docs Add comments for event type field Select all properties from atomic table in base events Change in to equals when comparing event type Rename _X_percent_reached columns to percent_reached_X Change var snowplow__events to snowplow__events_table in src_base.yml Avoid having only one argument in coalesce in macros Fix coalesce in a few more macros Disable mobile events and ad quartile events by default Select all columns from atomic table in bigquery, postgres, snowflake Fix subquery for snowflake Add sort, dist and cluster_by config to base_sessions_lifecycle manifest Unify macros to not add aliases Rename session_id to session_identifier Mention that play time counts rewatched content in docs Protect access to properties in optional contexts and improve docs Add check for at least one media player context Disable media_ad_views and media_ads in case media ad context is disabled Add session_identifier to media_ad_views Add a note in column documentation that several properties will be null if the media session entity is not available Handle cases when the table is empty during incremental run in media_stats Use the timestamp of the first ad event regardless of it's type for viewed_at in ad views and add a test for not null
agnessnowplow
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rlh1994
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2!
matus-tomlein
force-pushed
the
release/snowplow-media-player/0.6.0
branch
from
September 20, 2023 11:40
c67a82a
to
8ff20df
Compare
Just to explain the force-push – I forgot to add issue #45 to changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This release brings support for new media event and context entity schemas tracked using the JavaScript as well as mobile (iOS and Android) trackers. It also adds new features on top of the new media schemas such as ad tracking models and more accurate playback metrics.
Features
Add support for new Snowplow media event and entity schemas on Web and mobile (close #49)
Replace snowplow_web with a base that can be compatible with mobile events (close #45)
Under the hood
Update license to SPAL
Bump support for utils versions
🚨 Breaking Changes 🚨
This version requires a full refresh run if you have been using any previous versions. You will not be able to upgrade and have the package work without doing a full refresh. Check out the migration guide for more information when you upgrade.
Release Only Checklist