-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate media_id causing failures in the media_stats table #59
Labels
category:models
Related to the models in the package.
priority:medium
On the roadmap.
type:bug
Bugs or weaknesses. The issue has to contain steps to reproduce.
Comments
matus-tomlein
added
the
type:bug
Bugs or weaknesses. The issue has to contain steps to reproduce.
label
Oct 12, 2023
We'll work on this as part of the next major release so we can bundle in any other braking chagnes |
rlh1994
added
priority:medium
On the roadmap.
category:models
Related to the models in the package.
and removed
status:needs_triage
Needs maintainer triage.
labels
Oct 16, 2023
georgewoodhead
added a commit
that referenced
this issue
Nov 9, 2023
georgewoodhead
added a commit
that referenced
this issue
Nov 9, 2023
4 tasks
georgewoodhead
added a commit
that referenced
this issue
Nov 9, 2023
georgewoodhead
added a commit
that referenced
this issue
Nov 13, 2023
georgewoodhead
added a commit
that referenced
this issue
Nov 14, 2023
6 tasks
georgewoodhead
added a commit
that referenced
this issue
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:models
Related to the models in the package.
priority:medium
On the roadmap.
type:bug
Bugs or weaknesses. The issue has to contain steps to reproduce.
Describe the bug
This problem occurs in case of either:
media_type
ormedia_player_type
than other media events for the same content (the properties being set later in the tracking)This causes the
media_stats
table to break because it has a unique key on themedia_id
while also grouping by themedia_label
,media_type
andmedia_player_type
(see here).Steps to reproduce
Generate events which have different
media_type
tracked for the samemedia_label
.Expected results
We don't want to hide this problem as it signals an issue in the tracking. But we also don't want the model to break. Instead, it would be better if the
media_stats
table contained multiple rows for each of the tracked property combinations.Actual results
dbt jobs fail in this case.
Potential solutions
A couple of solutions are possible:
media_type
andmedia_player_type
to the surrogate key when generaingmedia_id
(here) – this would be a breaking change.media_stats
table to instead be a combined version of themedia_id
,media_label
,media_type
, andmedia_player_type
(or a surrogate key for them).The text was updated successfully, but these errors were encountered: