Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDP-1323 Handle initialization errors for GCP #91

Merged
merged 1 commit into from
Oct 25, 2024
Merged

PDP-1323 Handle initialization errors for GCP #91

merged 1 commit into from
Oct 25, 2024

Conversation

benjben
Copy link
Contributor

@benjben benjben commented Oct 25, 2024

No description provided.

istreeter
istreeter approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@istreeter istreeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

modules/gcp/src/main/scala/com.snowplowanalytics.snowplow.lakes/GcpApp.scala Outdated Show resolved Hide resolved
@benjben benjben force-pushed the PDP-1323_gcp_delta_init_error branch from 81aa6fd to 15bd044 Compare October 25, 2024 12:46
@benjben benjben merged commit 159afd6 into develop Oct 25, 2024
2 checks passed
@benjben benjben deleted the PDP-1323_gcp_delta_init_error branch October 25, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@istreeter istreeter istreeter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjben @istreeter