Pubsub source open more transport channels #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the pubsub SDK opened just a single transport channel (roughly equivalent to a TCP channel). Some snowplow apps we need to batch up a very large number of events from the source before acking. In those circumstances it is good to open more streaming pulls (a type of RPC) to keep the pubsub subscription healthy. But to open more streaming pulls we also need to open more transport channels (TCP channels) to support all the RPCs. This commit adds a new config parameter `maxPullsPerTransportChannel`. The default value 16 is good for most apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the pubsub SDK opened just a single transport channel (roughly equivalent to a TCP channel).
Some snowplow apps we need to batch up a very large number of events from the source before acking. In those circumstances it is good to open more streaming pulls (a type of RPC) to keep the pubsub subscription healthy. But to open more streaming pulls we also need to open more transport channels (TCP channels) to support all the RPCs.
This commit adds a new config parameter
maxPullsPerTransportChannel. The default value 16 is good for most apps.