Use Vector instead of List in transform methods
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istreeter
approved these changes
Mar 18, 2024
Currently, the transform functions in common-loaders return a [List](https://github.com/snowplow-incubator/common-streams/blob/0.2.1/modules/loaders-common/src/main/scala/com/snowplowanalytics/snowplow/loaders/transform/Transform.scala#L83). We construct the list by concatenating two lists: 1 for atomic fields and 1 for the self-describing entity fields ([this line](https://github.com/snowplow-incubator/common-streams/blob/0.2.1/modules/loaders-common/src/main/scala/com/snowplowanalytics/snowplow/loaders/transform/Transform.scala#L86)). The ::: operator is relatively expensive, especially for large lists. And this is a “hot” function which we invoke for every single event. If we switch the implementation to use Vector instead of List then it should be much more efficient to concatenate the two lists.
pondzix
force-pushed
the
use_vector_in_transform
branch
from
7bcc80f to
ff178b6
Compare
istreeter
added a commit
that referenced
this pull request
Mar 19, 2024
In #62 the transform method was improved to avoid the expensive `:::` operator. But we were still converting a `List` to a `Vector` for every single event. That conversion can be eliminated fairly easily.
istreeter
added a commit
that referenced
this pull request
Mar 24, 2024
In #62 the transform method was improved to avoid the expensive `:::` operator. But we were still converting a `List` to a `Vector` for every single event. That conversion can be eliminated fairly easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the transform functions in common-loaders return a List. We construct the list by concatenating two lists: 1 for atomic fields and 1 for the self-describing entity fields (this line).
The
:::operator is relatively expensive, especially for large lists. And this is a “hot” function which we invoke for every single event.If we switch the implementation to use Vector instead of List then it should be much more efficient to concatenate the two lists.