For structured data add ability to skip schemas matching criterion. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pondzix
force-pushed
the
skip_schemas_structured
branch
from
ca11ce8 to
40bea85
Compare
istreeter
reviewed
Mar 11, 2024
...common/src/main/scala/com/snowplowanalytics/snowplow/loaders/transform/NonAtomicFields.scala
Outdated
Show resolved
Hide resolved
pondzix
force-pushed
the
skip_schemas_structured
branch
from
86e3319 to
30e9862
Compare
istreeter
reviewed
Mar 11, 2024
...common/src/main/scala/com/snowplowanalytics/snowplow/loaders/transform/NonAtomicFields.scala
Outdated
Show resolved
Hide resolved
pondzix
force-pushed
the
skip_schemas_structured
branch
2 times, most recently
from
37e57f6 to
57d8e52
Compare
istreeter
approved these changes
Mar 13, 2024
...common/src/main/scala/com/snowplowanalytics/snowplow/loaders/transform/NonAtomicFields.scala
Outdated
Show resolved
Hide resolved
istreeter
approved these changes
Mar 18, 2024
pondzix
force-pushed
the
skip_schemas_structured
branch
2 times, most recently
from
49b36ad to
5d87275
Compare
Slightly different than filtering for unstructured events: * For unstructured, filtering is implemented in `Transform` by filtering matching entities from events. It's executed for each entity, for each event. * For structured, filtering is implemented in `NonAtomicFields.resolveTypes`. Resolving types is executed once per batch of events, so it's more efficient than doing it for each event in `Transform`. We can't use this approach for unstructured events because we don't have the step of resolving types.
pondzix
force-pushed
the
skip_schemas_structured
branch
from
5d87275 to
d07c1a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly different than filtering for unstructured events:
Transformby filtering matching entities from events. It's executed for each entity, for each event.NonAtomicFields.resolveTypes. Resolving types is executed once per batch of events, so it's more efficient than doing it for each event inTransform.We can't use this approach for unstructured events because we don't have the step of resolving types.