This repository has been archived by the owner on Aug 13, 2024. It is now read-only.
Fix formatting of logging options in compose file #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this modification, `docker-compose` fails to create the containers, with an error like: ``` ERROR: for example_stream-enrich_1 Cannot create container for service stream-enrich: json: cannot unmarshal number into Go value of type string ``` See docker/compose#4153
|
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
|
ah that's because we only use docker stack, thanks for catching! |
BenFradet
approved these changes
May 22, 2018
|
I signed CLA. |
|
Confirmed! @jackric has signed the Individual Contributor License Agreement. Thanks so much |
|
@jackric did you mean to close this? |
|
Didn't mean to close; I misinterpreted approval as merge... (reopening now) |
|
Thanks merged 👍 |
BenFradet
pushed a commit
that referenced
this pull request
Jun 18, 2018
Before this modification, `docker-compose` fails to create the containers, with an error like: ``` ERROR: for example_stream-enrich_1 Cannot create container for service stream-enrich: json: cannot unmarshal number into Go value of type string ``` See docker/compose#4153
BenFradet
pushed a commit
that referenced
this pull request
Jun 18, 2018
Before this modification, `docker-compose` fails to create the containers, with an error like: ``` ERROR: for example_stream-enrich_1 Cannot create container for service stream-enrich: json: cannot unmarshal number into Go value of type string ``` See docker/compose#4153
BenFradet
pushed a commit
that referenced
this pull request
Jun 18, 2018
Before this modification, `docker-compose` fails to create the containers, with an error like: ``` ERROR: for example_stream-enrich_1 Cannot create container for service stream-enrich: json: cannot unmarshal number into Go value of type string ``` See docker/compose#4153
BenFradet
pushed a commit
that referenced
this pull request
Jun 18, 2018
Before this modification, `docker-compose` fails to create the containers, with an error like: ``` ERROR: for example_stream-enrich_1 Cannot create container for service stream-enrich: json: cannot unmarshal number into Go value of type string ``` See docker/compose#4153
BenFradet
pushed a commit
that referenced
this pull request
Jun 18, 2018
Before this modification, `docker-compose` fails to create the containers, with an error like: ``` ERROR: for example_stream-enrich_1 Cannot create container for service stream-enrich: json: cannot unmarshal number into Go value of type string ``` See docker/compose#4153
knservis
pushed a commit
that referenced
this pull request
Aug 31, 2018
Before this modification, `docker-compose` fails to create the containers, with an error like: ``` ERROR: for example_stream-enrich_1 Cannot create container for service stream-enrich: json: cannot unmarshal number into Go value of type string ``` See docker/compose#4153
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this modification,
docker-composefails to create the containers, with an error like:See docker/compose#4153