Skip to content
This repository has been archived by the owner on Aug 13, 2024. It is now read-only.

Add support for beam-enrich CLI params in k8s-dataflow #137

Closed
peel opened this issue Feb 18, 2020 · 4 comments
Closed

Add support for beam-enrich CLI params in k8s-dataflow #137

peel opened this issue Feb 18, 2020 · 4 comments

Comments

@peel
Copy link

peel commented Feb 18, 2020

No description provided.

@chuwy
Copy link
Contributor

chuwy commented Feb 18, 2020

Its not only beam-enrich. BQ Loader will also use the same parameters.

peel pushed a commit that referenced this issue Feb 18, 2020
Add support for beam-enrich CLI params in k8s-dataflow (closes #137)
ca0ec3f
@chuwy
Copy link
Contributor

chuwy commented Feb 18, 2020

Oh, I thought you meant labels.

@peel
Copy link
Author

peel commented Feb 18, 2020 •
edited
Loading

Nope, this is strictly about being able to reuse beam-enrich's CLI params for graceful shutdown if for some reason bucket for dataflow job has not been created/removed.

edit: snowplow-incubator/snowplow-google-cloud-storage-loader#36

peel pushed a commit that referenced this issue Feb 18, 2020
Add support for beam-enrich CLI params in k8s-dataflow (closes #137)
48f3fc5
@chuwy
Copy link
Contributor

chuwy commented Feb 18, 2020

Are we sure it cannot happen for BQ Loader job?

@peel peel closed this as completed in 75bc2fd Feb 19, 2020
peel pushed a commit that referenced this issue Feb 21, 2020
Add support for beam-enrich CLI params in k8s-dataflow (closes #137)
e3669c8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peel @chuwy