Skip to content
This repository has been archived by the owner on Aug 13, 2024. It is now read-only.

Update README #4

Closed
alexanderdean opened this issue Dec 29, 2013 · 4 comments
Closed

Update README #4

alexanderdean opened this issue Dec 29, 2013 · 4 comments
Assignees

Comments

@alexanderdean
Copy link
Contributor

Can remove:

Please note: Amazon Kinesis is currently in private beta. Being on the Kinesis private beta is a pre-requisite to building and running this project.

And:

Now manually copy the relevant jar from your Amazon Kinesis SDK Preview:

$ cd kinesis-example-scala-producer
$ cp ~/downloads/AmazonKinesisSDK-preview/aws-java-sdk-1.6.4/lib/aws-java-sdk-1.6.4.jar lib/
$ sbt assembly

@ghost ghost assigned bamos Dec 29, 2013
bamos pushed a commit that referenced this issue Dec 29, 2013
@bamos
Copy link
Contributor

bamos commented Dec 29, 2013

Hi Alex, should we keep FAQ and Roadmap? Also, just curious, does this say to use sbt assembly then java -jar rather than sbt run to avoid sbt overhead, or is there another reason?

bamos pushed a commit that referenced this issue Dec 29, 2013
@alexanderdean
Copy link
Contributor Author

Ah right - do remove FAQ and Roadmap by all means.

The suggestions around assembly and java -jar are so that people can turn these into deployable fat jars and run them on a server without sbt - but I agree, that doesn't make a whole lot of sense for 'test' apps like these.

I think it would make total sense to remove these instructions and revert to sbt run. (Whereas for an actual app like the Scala Stream Collector, making a fatjar for deployment does make a lot of sense)...

bamos pushed a commit that referenced this issue Dec 29, 2013
@bamos
Copy link
Contributor

bamos commented Dec 29, 2013

Changed, and I've left the sbt assembly dependency just in case somebody still wants it. Let me know if there's anything else on the README!

@bamos bamos closed this as completed Dec 29, 2013
@alexanderdean
Copy link
Contributor Author

Nice one. Good idea keeping the sbt-assembly dep as someone may want to fork and evolve this into their own app, then they have the sbt-assembly ready to use...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants