Skip to content
This repository has been archived by the owner on Aug 2, 2020. It is now read-only.

Fix defaut top level targets #659

Merged
merged 2 commits into from
Aug 27, 2018
Merged

Fix defaut top level targets #659

merged 2 commits into from
Aug 27, 2018

Conversation

snowleopard
Copy link
Owner

@snowleopard snowleopard commented Aug 26, 2018

This does the following:

@snowleopard snowleopard merged commit 8ec50a5 into master Aug 27, 2018
@snowleopard snowleopard deleted the fix-top-level-targets branch August 27, 2018 00:31
@alpmestan
Copy link
Collaborator

Does this mean cross-compilers don't get their ghc-tags (cross-compilers are stage 1 GHCs) anymore ?

@snowleopard
Copy link
Owner Author

@alpmestan According to this commit ghctags should be built with Stage2 compiler.

@snowleopard
Copy link
Owner Author

Also, this note seems relevant: Note [No stage2 packages when CrossCompiling or Stage1Only].

https://github.com/ghc/ghc/blob/3bdf0d01ff47977830ada30ce85f174098486e23/ghc.mk#L1499-L1546

@alpmestan
Copy link
Collaborator

Oh, nevermind then!

@snowleopard
Copy link
Owner Author

Actually, there is this bit:

# Here's why:
#  - first of all, ghc-stage1 can't use stage0's ghc library (it's too old)
#  - neither do we register the ghc library (compiler/stage1) that we build
#    with stage0. TODO Why not? We do build it...
#  - as a result, we need to a) use ghc-stage2 to build packages that depend on
#    the ghc library (e.g. ghctags [4]) and b) exclude those packages when
#    ghc-stage2 is not available.

See the TODO -- I believe now we do register the ghc library built in Stage0, so presumably this means we could indeed now build all its dependencies in Stage1. Let me create a separate issue to discuss this.

@snowleopard
Copy link
Owner Author

Here is the issue: #661.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants