Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1852934: Add support for DataFrame.map method #2754

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

SNOW-1852934: Add support for DataFrame.map method #2754

wants to merge 2 commits into from
+31 −18

Conversation

sfc-gh-nkumar
Copy link
Contributor

@sfc-gh-nkumar sfc-gh-nkumar commented Dec 12, 2024 •
edited by sfc-gh-helmeleegy
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1852934

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

In pandas 2.1.0 DataFrame.applymap was renamed to DataFrame.map. We already have support for DataFrame.applymap, added redirect to support DataFrame.map as well.

@sfc-gh-nkumar sfc-gh-nkumar requested a review from a team as a code owner December 12, 2024 19:55
@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1852934-frame-map branch from d365518 to 710f233 Compare December 12, 2024 20:53
sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

sfc-gh-jkew
sfc-gh-jkew requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-jkew sfc-gh-jkew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extraneous comment it seems

tests/integ/modin/frame/test_applymap.py Outdated Show resolved Hide resolved
@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-1852934-frame-map branch from 653310a to 001bf50 Compare December 12, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-jjiao sfc-gh-jjiao Awaiting requested review from sfc-gh-jjiao sfc-gh-jjiao is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-jkew sfc-gh-jkew Awaiting requested review from sfc-gh-jkew

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-nkumar @sfc-gh-jkew @sfc-gh-helmeleegy