Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1844280: fix stored proc pytest option issue #2709

Conversation

sfc-gh-aling
Copy link
Contributor

@sfc-gh-aling sfc-gh-aling commented Dec 4, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

in stored proc it's unable to find pytest option "local_testing_mode".
giving a default value resolves the issue, however, it's still unknown why this doesn't happen before but happen after the IR PR merge.
probably because the fixture is referenced somewhere by the new tests. for now let's fix the issue to unblock release

successful running sproc precommit test job: 1490

Copy link

github-actions bot commented Dec 4, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

Copy link

github-actions bot commented Dec 4, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

Copy link

github-actions bot commented Dec 4, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@sfc-gh-aling sfc-gh-aling changed the title SNOW-1844280: remove unused parameter SNOW-1844280: fix stored proc pytest option issue Dec 4, 2024
@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review December 4, 2024 21:34
@sfc-gh-aling sfc-gh-aling requested a review from a team as a code owner December 4, 2024 21:34
@sfc-gh-aling sfc-gh-aling merged commit 8cd7d40 into main Dec 4, 2024
45 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-1844280-fix-sproc-precommit-test-failure-related-to-local-testing-mode-fixture branch December 4, 2024 22:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants