Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for iceberg table with snowflake catalog #539

Merged
merged 14 commits into from
Oct 29, 2024
Merged

Add support for iceberg table with snowflake catalog #539

merged 14 commits into from
Oct 29, 2024

Conversation

sfc-gh-jvasquezrojas
Copy link
Collaborator

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas commented Oct 23, 2024 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1514024

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

  • Add support for Iceberg Table with Snowflake Catalog
  • Add ClusterByOption and SnowflakeTable to create normal tables
  • Fix snowflake_clusterby not working with explicit expressions

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas marked this pull request as ready for review October 23, 2024 22:17
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas requested a review from a team as a code owner October 23, 2024 22:17
sfc-gh-mraba
sfc-gh-mraba reviewed Oct 25, 2024
View reviewed changes
tests/test_core.py Outdated Show resolved Hide resolved
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas force-pushed the add_support_for_iceberg_table_with_snowflake_catalog branch from e570543 to 705535b Compare October 25, 2024 14:16
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas merged commit 14be282 into main Oct 29, 2024
45 checks passed
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas deleted the add_support_for_iceberg_table_with_snowflake_catalog branch October 29, 2024 13:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mraba sfc-gh-mraba sfc-gh-mraba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jvasquezrojas @sfc-gh-mraba