Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic options in order to support Iceberg Table in following PR #537

Merged

Conversation

sfc-gh-jvasquezrojas
Copy link
Collaborator

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas commented Oct 17, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1514024

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

  • Add support for REFRESH_MODE option
  • Add new exceptions to validate parameters and how options are created
  • Remove support for TableOption in SqlAlchemyTables, now they only can be added to SnowflakeTables.
  • Replace how options are defined in CustomTables to mimic how tables are created in snowflake.

image

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas marked this pull request as ready for review October 17, 2024 20:01
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas requested a review from a team as a code owner October 17, 2024 20:01
Comment on lines +13 to +30
__all__ = [
# Options
"IdentifierOption",
"LiteralOption",
"KeywordOption",
"AsQueryOption",
"TargetLagOption",
# Enums
"TimeUnit",
"SnowflakeKeyword",
"TableOptionKey",
# Types
"IdentifierOptionType",
"LiteralOptionType",
"AsQueryOptionType",
"TargetLagOptionType",
"KeywordOptionType",
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
__all__ = [
# Options
"IdentifierOption",
"LiteralOption",
"KeywordOption",
"AsQueryOption",
"TargetLagOption",
# Enums
"TimeUnit",
"SnowflakeKeyword",
"TableOptionKey",
# Types
"IdentifierOptionType",
"LiteralOptionType",
"AsQueryOptionType",
"TargetLagOptionType",
"KeywordOptionType",
]
_options = [
"IdentifierOption",
"LiteralOption",
"KeywordOption",
"AsQueryOption",
"TargetLagOption",
]
_enums = [
"TimeUnit",
"SnowflakeKeyword",
"TableOptionKey",
]
_types = [
"IdentifierOptionType",
"LiteralOptionType",
"AsQueryOptionType",
"TargetLagOptionType",
"KeywordOptionType",
]
__all__ = _options + _enums + _types

@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas merged commit e783197 into main Oct 22, 2024
47 checks passed
@sfc-gh-jvasquezrojas sfc-gh-jvasquezrojas deleted the support_for_table_option_and_iceberg_tables branch October 22, 2024 15:18
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants