Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GEOMETRY type #427

Conversation

zachflanders
Copy link

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-871115: Add GEOMETRY support to snowflake-sqlalchemy #426

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    This code change adds support for the GEOMETRY data type. It closely follows this effort to add the GEOGRAPHY data type.

@github-actions
Copy link

github-actions bot commented Jul 18, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@zachflanders
Copy link
Author

zachflanders commented Jul 18, 2023

It appears that the link to the Contributor License Agreement is broken, but I will post the comment to pass the first workflow item.

@zachflanders
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@zachflanders
Copy link
Author

recheck

@@ -49,6 +49,7 @@
DOUBLE,
FIXED,
GEOGRAPHY,
GEOMETRY,
Copy link
Collaborator

@sfc-gh-aling sfc-gh-aling Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add the class in __all__ on line 70 as well

@sfc-gh-aling
Copy link
Collaborator

sfc-gh-aling commented Jul 27, 2023

hi @zachflanders , thanks for the PR, it looks great to me.
I originally wanted to do some minor updates to the PR however I don't find myself having the rights to contribute to your fork.

so I created another one: #429

@sfc-gh-aling
Copy link
Collaborator

thanks for your contribution! I merged the other PR, it shall be carried in our next release

@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-871115: Add GEOMETRY support to snowflake-sqlalchemy
2 participants