-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GEOMETRY
type
#427
Add support for GEOMETRY
type
#427
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
It appears that the link to the Contributor License Agreement is broken, but I will post the comment to pass the first workflow item. |
I have read the CLA Document and I hereby sign the CLA |
recheck |
@@ -49,6 +49,7 @@ | |||
DOUBLE, | |||
FIXED, | |||
GEOGRAPHY, | |||
GEOMETRY, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add the class in __all__
on line 70 as well
hi @zachflanders , thanks for the PR, it looks great to me. so I created another one: #429 |
thanks for your contribution! I merged the other PR, it shall be carried in our next release |
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-871115: Add
GEOMETRY
support to snowflake-sqlalchemy #426Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This code change adds support for the
GEOMETRY
data type. It closely follows this effort to add theGEOGRAPHY
data type.