Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1475664: Move additional error handling from BufferedTopicPartitionChannel to fix E2E test #865

Merged
merged 1 commit into from
Jun 13, 2024
Merged

SNOW-1475664: Move additional error handling from BufferedTopicPartitionChannel to fix E2E test #865

merged 1 commit into from
Jun 13, 2024

Conversation

sfc-gh-akowalczyk
Copy link
Contributor

…make TestSnowpipeStreamingSchemaMappingDLQ passing

Overview

SNOW-1475664

Fixing TestSnowpipeStreamingSchemaMappingDLQ test by moving some part of additional validation from BufferedTopicPartitionChannel.

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-akowalczyk
Move additional error handling from BufferedTopicPartitionChannel to …
a37cb9c 
…make TestSnowpipeStreamingSchemaMappingDLQ passing
@sfc-gh-akowalczyk sfc-gh-akowalczyk requested a review from a team as a code owner June 12, 2024 12:54
@sfc-gh-akowalczyk sfc-gh-akowalczyk merged commit 990d9bd into master Jun 13, 2024
79 of 81 checks passed
@sfc-gh-akowalczyk sfc-gh-akowalczyk deleted the akowalczyk/snow-1475664-fix-TestSnowpipeStreamingSchemaMappingDLQ branch June 13, 2024 06:35
ConfluentSemaphore pushed a commit to confluentinc/snowflake-kafka-connector that referenced this pull request Aug 6, 2024
@sfc-gh-akowalczyk @sudeshwasnik
SNOW-1475664: Move additional error handling from BufferedTopicPartit…
0fa43eb 
…ionChannel to fix E2E test (snowflakedb#865)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-wtrefon sfc-gh-wtrefon sfc-gh-wtrefon approved these changes

@sfc-gh-gjachimko sfc-gh-gjachimko sfc-gh-gjachimko approved these changes

@sfc-gh-lshcharbaty sfc-gh-lshcharbaty sfc-gh-lshcharbaty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-akowalczyk @sfc-gh-lshcharbaty @sfc-gh-gjachimko @sfc-gh-wtrefon