Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1348656 Migrate RecordContentTest to JUnit5 #828

Merged
merged 4 commits into from
Apr 30, 2024
Merged

SNOW-1348656 Migrate RecordContentTest to JUnit5 #828

merged 4 commits into from
Apr 30, 2024

Conversation

sfc-gh-mbobowski
Copy link
Contributor

@sfc-gh-mbobowski sfc-gh-mbobowski commented Apr 29, 2024 •
edited
Loading

Overview

SNOW-1348656 Kafka Processing error not sent to DLQ correctly.

Initial refactoring:

  • migration to JUnit5
  • removing code duplication with @ParameterizedTest
  • adding builder for SinkRecord

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

sfc-gh-lshcharbaty
sfc-gh-lshcharbaty approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-lshcharbaty sfc-gh-lshcharbaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet another test has been migrated to junit5.
Nice job!

src/test/java/com/snowflake/kafka/connector/records/RecordContentTest.java Outdated Show resolved Hide resolved
src/test/java/com/snowflake/kafka/connector/records/RecordContentTest.java Outdated Show resolved Hide resolved
src/test/java/com/snowflake/kafka/connector/records/RecordContentTest.java Outdated Show resolved Hide resolved
src/test/java/com/snowflake/kafka/connector/records/RecordContentTest.java Outdated Show resolved Hide resolved
src/test/java/com/snowflake/kafka/connector/records/RecordContentTest.java Outdated Show resolved Hide resolved
sfc-gh-gjachimko
sfc-gh-gjachimko approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-gjachimko sfc-gh-gjachimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no remarks except ones already raised by Lex

@sfc-gh-mbobowski
Copy link
Contributor Author

Close / reopen because of build hang

@sfc-gh-mbobowski sfc-gh-mbobowski merged commit 66d9aa8 into master Apr 30, 2024
80 of 81 checks passed
@sfc-gh-mbobowski sfc-gh-mbobowski deleted the mbobowski-SNOW-1348656-refactor branch April 30, 2024 15:58
ConfluentSemaphore pushed a commit to confluentinc/snowflake-kafka-connector that referenced this pull request Aug 6, 2024
@sfc-gh-mbobowski @sudeshwasnik
SNOW-1348656 Migrate RecordContentTest to JUnit5 (snowflakedb#828)
0985bd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-gjachimko sfc-gh-gjachimko sfc-gh-gjachimko approved these changes

@sfc-gh-lshcharbaty sfc-gh-lshcharbaty sfc-gh-lshcharbaty approved these changes

@sfc-gh-japatel sfc-gh-japatel Awaiting requested review from sfc-gh-japatel

@sfc-gh-tzhang sfc-gh-tzhang Awaiting requested review from sfc-gh-tzhang

@sfc-gh-tjones sfc-gh-tjones Awaiting requested review from sfc-gh-tjones

@sfc-gh-rcheng sfc-gh-rcheng Awaiting requested review from sfc-gh-rcheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-mbobowski @sfc-gh-lshcharbaty @sfc-gh-gjachimko