Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-896818 Limited support for encrypted private keys #1671

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

sfc-gh-wfateem
Copy link
Collaborator

@sfc-gh-wfateem sfc-gh-wfateem commented Mar 17, 2024

Added the JVM argument -Dnet.snowflake.jdbc.enableBouncyCastle to allow the JDBC
driver to leverage the BouncyCastle provider to decrypt private keys instead of
using the default security providers in the JDK. This helps work around a
limitation with being able to decrypt private keys with PBES2 parameters.
Ref: https://bugs.openjdk.org/browse/JDK-8228481

@sfc-gh-wfateem sfc-gh-wfateem requested a review from a team as a code owner March 17, 2024 21:14
@sfc-gh-wfateem sfc-gh-wfateem marked this pull request as draft March 17, 2024 21:14
@sfc-gh-wfateem sfc-gh-wfateem force-pushed the SNOW-896818-private-key-decrypt branch from dc307e3 to 2225cec Compare March 18, 2024 17:15
@sfc-gh-wfateem sfc-gh-wfateem force-pushed the SNOW-896818-private-key-decrypt branch 2 times, most recently from ac16854 to 6187e9f Compare March 19, 2024 11:44
@sfc-gh-wfateem sfc-gh-wfateem force-pushed the SNOW-896818-private-key-decrypt branch 6 times, most recently from 0c3352b to 8cb76ac Compare March 26, 2024 11:56
@sfc-gh-wfateem sfc-gh-wfateem force-pushed the SNOW-896818-private-key-decrypt branch from 8cb76ac to 36c5be8 Compare March 27, 2024 16:30
Copy link

gitguardian bot commented Mar 27, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@KevinMellott91
Copy link

I noticed that a new release is coming out soon (or maybe already has?). Wondering if there is any chance to include this PR into that release or perhaps a follow-up patch?

Asking because I'm wanting to use this driver within Flyway for a current project, but I'm unable to do so without this update for security reasons. Thanks in advance for the consideration and happy to help out if there is anything I can do.

@sfc-gh-wfateem
Copy link
Collaborator Author

Hi @KevinMellott91,
It hasn't made it into this release.
We're just getting the PR reviewed. Once that's complete we'll be merging the PR to the main branch and will be included in the next release.
Once it's merged though, you can build the PR and just use that until an official release is made.
Hope this helps.

@sfc-gh-wfateem sfc-gh-wfateem force-pushed the SNOW-896818-private-key-decrypt branch 3 times, most recently from eb4f7f9 to 7ac1d1d Compare April 9, 2024 20:07
@sfc-gh-wfateem sfc-gh-wfateem force-pushed the SNOW-896818-private-key-decrypt branch 3 times, most recently from 72736e8 to 4efb707 Compare April 10, 2024 19:45
@sfc-gh-wfateem sfc-gh-wfateem force-pushed the SNOW-896818-private-key-decrypt branch 3 times, most recently from af7bf07 to fe1bdb7 Compare April 10, 2024 20:19
@sfc-gh-wfateem sfc-gh-wfateem force-pushed the SNOW-896818-private-key-decrypt branch 4 times, most recently from 8670417 to 9df55a2 Compare April 12, 2024 11:29
Added the JVM argument -Dnet.snowflake.jdbc.enableBouncyCastle to allow the JDBC
driver to leverage the BouncyCastle provider to decrypt private keys instead of
using the default security providers in the JDK. This helps work around a
limitation with being able to decrypt private keys with PBES2 parameters.
Ref: https://bugs.openjdk.org/browse/JDK-8228481
@sfc-gh-wfateem sfc-gh-wfateem force-pushed the SNOW-896818-private-key-decrypt branch from 87bd495 to e0b1a9a Compare April 12, 2024 11:43
@sfc-gh-wfateem sfc-gh-wfateem force-pushed the SNOW-896818-private-key-decrypt branch from 3f8b172 to 01c2328 Compare April 12, 2024 12:40
@sfc-gh-wfateem sfc-gh-wfateem merged commit 5ff9e9a into master Apr 12, 2024
35 of 37 checks passed
@sfc-gh-wfateem sfc-gh-wfateem deleted the SNOW-896818-private-key-decrypt branch April 12, 2024 14:25
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
@sfc-gh-wfateem
Copy link
Collaborator Author

Fixes #1683

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants