-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-896818 Limited support for encrypted private keys #1671
Conversation
dc307e3
to
2225cec
Compare
ac16854
to
6187e9f
Compare
src/main/java/net/snowflake/client/core/SessionUtilKeyPair.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/SessionUtilKeyPair.java
Outdated
Show resolved
Hide resolved
src/main/java/net/snowflake/client/core/SessionUtilKeyPair.java
Outdated
Show resolved
Hide resolved
0c3352b
to
8cb76ac
Compare
8cb76ac
to
36c5be8
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
36c5be8
to
e052993
Compare
I noticed that a new release is coming out soon (or maybe already has?). Wondering if there is any chance to include this PR into that release or perhaps a follow-up patch? Asking because I'm wanting to use this driver within Flyway for a current project, but I'm unable to do so without this update for security reasons. Thanks in advance for the consideration and happy to help out if there is anything I can do. |
Hi @KevinMellott91, |
src/test/java/net/snowflake/client/jdbc/ConnectionLatestIT.java
Outdated
Show resolved
Hide resolved
eb4f7f9
to
7ac1d1d
Compare
src/main/java/net/snowflake/client/core/SessionUtilKeyPair.java
Outdated
Show resolved
Hide resolved
72736e8
to
4efb707
Compare
af7bf07
to
fe1bdb7
Compare
FIPS/src/test/java/net/snowflake/client/jdbc/ConnectionFipsIT.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/jdbc/ConnectionLatestIT.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/jdbc/ConnectionLatestIT.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/jdbc/ConnectionLatestIT.java
Outdated
Show resolved
Hide resolved
src/test/java/net/snowflake/client/jdbc/ConnectionLatestIT.java
Outdated
Show resolved
Hide resolved
8670417
to
9df55a2
Compare
Added the JVM argument -Dnet.snowflake.jdbc.enableBouncyCastle to allow the JDBC driver to leverage the BouncyCastle provider to decrypt private keys instead of using the default security providers in the JDK. This helps work around a limitation with being able to decrypt private keys with PBES2 parameters. Ref: https://bugs.openjdk.org/browse/JDK-8228481
87bd495
to
e0b1a9a
Compare
3f8b172
to
01c2328
Compare
Fixes #1683 |
Added the JVM argument -Dnet.snowflake.jdbc.enableBouncyCastle to allow the JDBC
driver to leverage the BouncyCastle provider to decrypt private keys instead of
using the default security providers in the JDK. This helps work around a
limitation with being able to decrypt private keys with PBES2 parameters.
Ref: https://bugs.openjdk.org/browse/JDK-8228481