Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1650124: Pass Azure SAS Token via params #2060

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

sfc-gh-jrose
Copy link
Contributor

@sfc-gh-jrose sfc-gh-jrose commented Sep 19, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1650124

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    This PR passes params through to the requests library so that Azure tokens can be passed to requests via params. This allows logging to avoid printing the secret information.

  4. (Optional) PR for stored-proc connector:
    Azure storage client does not exist in stored proc connector.

@sfc-gh-jrose sfc-gh-jrose added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Sep 19, 2024
@sfc-gh-jrose sfc-gh-jrose force-pushed the jrose_snow_1650124_azure_sas_token branch from 09d3cb5 to 03b99f7 Compare October 22, 2024 16:42
Copy link

gitguardian bot commented Oct 22, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sfc-gh-jrose sfc-gh-jrose force-pushed the jrose_snow_1650124_azure_sas_token branch from 03b99f7 to 697da44 Compare October 22, 2024 16:52
@sfc-gh-jrose sfc-gh-jrose merged commit d73afee into main Oct 22, 2024
94 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_1650124_azure_sas_token branch October 22, 2024 20:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants