Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1657037: Remove secrets from debug logs. #2058

Merged
merged 2 commits into from
Oct 22, 2024
Merged

SNOW-1657037: Remove secrets from debug logs. #2058

merged 2 commits into from
Oct 22, 2024

Conversation

sfc-gh-jrose
Copy link
Contributor

@sfc-gh-jrose sfc-gh-jrose commented Sep 19, 2024 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1657037 SNOW-1642759

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.
    This change removes a log line that would leak secrets as well as changes another from a blacklist approach to a whitelist approach.

  4. (Optional) PR for stored-proc connector:
    Stored proc does not share the auth submodule.

@sfc-gh-jrose sfc-gh-jrose added DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md labels Sep 19, 2024
@sfc-gh-jrose sfc-gh-jrose force-pushed the jrose_snow_1657037_filter_secrets branch from 22bfa6c to 8b61823 Compare September 19, 2024 21:05
sfc-gh-aling
sfc-gh-aling reviewed Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-aling sfc-gh-aling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add some unit test for this?

@sfc-gh-jrose sfc-gh-jrose force-pushed the jrose_snow_1657037_filter_secrets branch from a12e2e9 to 2d4d52f Compare October 22, 2024 16:49
@sfc-gh-jrose sfc-gh-jrose force-pushed the jrose_snow_1657037_filter_secrets branch from 2d4d52f to bfa9efd Compare October 22, 2024 16:51
@sfc-gh-jrose sfc-gh-jrose merged commit dbc9284 into main Oct 22, 2024
94 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_1657037_filter_secrets branch October 22, 2024 20:01
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

Assignees
No one assigned
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jrose @sfc-gh-aling @sfc-gh-aalam