Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-943025: improve flaky OOB test #1782

Conversation

sfc-gh-aling
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

SNOW-943025, Fixes flaky OOB test

since pytests can run test in parallel and TelemetryService is a singleton, other tests might encounter error logged into the queue of the OOB Telemetry simultaneously leading to assert telemetry.size() == 0 failure, here we check that the OCSP exception event in the test is flushed

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-aling sfc-gh-aling added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Oct 20, 2023
@sfc-gh-aling sfc-gh-aling enabled auto-merge (squash) October 20, 2023 21:43
Copy link
Contributor

@sfc-gh-stan sfc-gh-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Do you think we should rewrite the tests or configure some tests to not run in parallel?

@sfc-gh-aling sfc-gh-aling merged commit 78bdaae into main Oct 20, 2023
78 of 79 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-943025-connector-flaky-test-test-telemetry-oob-simple-flush branch October 20, 2023 22:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2023
@sfc-gh-aling
Copy link
Collaborator Author

@sfc-gh-stan I prefer rewriting the tests (my PR is kinda rewriting the test).
but I don't want to spend time refactoring the whole test suites, so far it's only this test case causing issue.
so I will hold off my efforts until I think it's necessary to do so

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants