Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "SNOW-843716: cryptography dep cleanup (#1773)" #1778

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Revert "SNOW-843716: cryptography dep cleanup (#1773)" #1778

merged 1 commit into from
Oct 17, 2023

Conversation

sfc-gh-aling
Copy link
Collaborator

@sfc-gh-aling sfc-gh-aling commented Oct 17, 2023 •
edited
Loading

This reverts commit 6398696.

snowsql depends on the two other cryptography libs
removing the dependency breaks snowsql

this is a BCR change

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

sfc-gh-mkeller
sfc-gh-mkeller approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-aling sfc-gh-aling enabled auto-merge (squash) October 17, 2023 21:14
@sfc-gh-aling sfc-gh-aling merged commit 5b61af7 into main Oct 17, 2023
76 of 78 checks passed
@sfc-gh-aling sfc-gh-aling deleted the revert-SNOW-843716 branch October 17, 2023 21:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mkeller sfc-gh-mkeller sfc-gh-mkeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-aling @sfc-gh-mkeller