Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-901898: fix flaky oob test #1714

Merged
merged 1 commit into from
Aug 29, 2023
Merged

SNOW-901898: fix flaky oob test #1714

merged 1 commit into from
Aug 29, 2023

Conversation

sfc-gh-aling
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-901898, clean up the buffer before the test

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-aling sfc-gh-aling added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Aug 28, 2023
@sfc-gh-aling sfc-gh-aling merged commit 58e2036 into main Aug 29, 2023
@sfc-gh-aling sfc-gh-aling deleted the SNOW-901898-fix-flaky-connector-oob-test branch August 29, 2023 23:04
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-mkeller sfc-gh-mkeller Awaiting requested review from sfc-gh-mkeller

@sfc-gh-stan sfc-gh-stan Awaiting requested review from sfc-gh-stan

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-aling @sfc-gh-aalam