Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-877652: Remove __del__ #1669

Merged
merged 1 commit into from
Jul 28, 2023
Merged

SNOW-877652: Remove __del__ #1669

merged 1 commit into from
Jul 28, 2023

Conversation

sfc-gh-aling
Copy link
Collaborator

@sfc-gh-aling sfc-gh-aling commented Jul 27, 2023 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-877652

follow up item: https://snowflakecomputing.atlassian.net/browse/SNOW-877785

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-aling sfc-gh-aling added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 27, 2023
sfc-gh-mkeller
sfc-gh-mkeller approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed SNOW-878091 to follow up

🚢 🚢

@sfc-gh-aling sfc-gh-aling merged commit 523e5b1 into main Jul 28, 2023
@sfc-gh-aling sfc-gh-aling deleted the SNOW-877652-connector-remove-del-in-cache branch July 28, 2023 02:34
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mkeller sfc-gh-mkeller sfc-gh-mkeller approved these changes

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-aling @sfc-gh-mkeller