Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-862917: Trigger lambda tests on GHA #1647

Merged
merged 13 commits into from
Jul 19, 2023
Merged

SNOW-862917: Trigger lambda tests on GHA #1647

merged 13 commits into from
Jul 19, 2023

Conversation

sfc-gh-aalam
Copy link
Collaborator

@sfc-gh-aalam sfc-gh-aalam commented Jul 17, 2023 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-862917

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    This PR adds a docker file which sets up a AWS Lambda Runtime Interface Emulator and runs a docker container to run the lambda tests inside the emulated image.

@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 17, 2023
@sfc-gh-aalam sfc-gh-aalam changed the title initial commit SNOW-862917: Shell Scripts to trigger lambda tests on GH and Jenkins Jul 18, 2023
@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review July 18, 2023 23:42
@sfc-gh-aalam sfc-gh-aalam requested review from a team, sfc-gh-aling, sfc-gh-hpu and sfc-gh-mkeller and removed request for a team and sfc-gh-hpu July 18, 2023 23:42
@sfc-gh-aalam sfc-gh-aalam changed the title SNOW-862917: Shell Scripts to trigger lambda tests on GH and Jenkins SNOW-862917: Trigger lambda tests on GHA Jul 19, 2023
sfc-gh-sfan
sfc-gh-sfan reviewed Jul 19, 2023
View reviewed changes
.github/workflows/build_test.yml Outdated
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need 3.11? Similar question on docker files.

Copy link
Collaborator Author

@sfc-gh-aalam sfc-gh-aalam Jul 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws runtime interface is not yet available for 3.11

maybe I'm wrong about this. Last time I checked, it wasn't supported

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it was added in the last two months. I'm adding 3.11 support as well

@codecov
Copy link

codecov bot commented Jul 19, 2023 •
edited
Loading

Codecov Report

Merging #1647 (b16a3c5) into main (64fd9cc) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head b16a3c5 differs from pull request most recent head 44ece5c. Consider uploading reports for the commit 44ece5c to get more accurate results

@@            Coverage Diff             @@
##             main    #1647      +/-   ##
==========================================
+ Coverage   83.07%   83.12%   +0.05%     
==========================================
  Files          64       64              
  Lines        9250     9250              
  Branches     1350     1350              
==========================================
+ Hits         7684     7689       +5     
+ Misses       1225     1223       -2     
+ Partials      341      338       -3

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-aalam sfc-gh-aalam merged commit 90ee69d into main Jul 19, 2023
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-SNOW-862917-create-shell-scripts-to-run-lambda-tests-on-docker branch July 19, 2023 20:37
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-sfan sfc-gh-sfan sfc-gh-sfan approved these changes

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling sfc-gh-aling was automatically assigned from snowflakedb/snowpark-python-api

@sfc-gh-mkeller sfc-gh-mkeller Awaiting requested review from sfc-gh-mkeller

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-aalam @sfc-gh-sfan