Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-830394 adding better configuration file changelog entry #1638

Merged
merged 4 commits into from
Jul 13, 2023
Merged

SNOW-830394 adding better configuration file changelog entry #1638

merged 4 commits into from
Jul 13, 2023

Conversation

sfc-gh-mkeller
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-830394

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Just a better explanation to what the new feature can do

@sfc-gh-mkeller sfc-gh-mkeller self-assigned this Jul 12, 2023
sfc-gh-stan
sfc-gh-stan reviewed Jul 12, 2023
View reviewed changes
DESCRIPTION.md Outdated Show resolved Hide resolved
sfc-gh-stan
sfc-gh-stan approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@sfc-gh-stan sfc-gh-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One NIT, otherwise LGTM.

sfc-gh-sfan
sfc-gh-sfan approved these changes Jul 12, 2023
View reviewed changes
DESCRIPTION.md Outdated Show resolved Hide resolved
sfc-gh-mheavin
sfc-gh-mheavin reviewed Jul 13, 2023
View reviewed changes
DESCRIPTION.md Outdated Show resolved Hide resolved
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/SNOW-830394-better_changelog branch from c070451 to 5909f10 Compare July 13, 2023 19:09
@sfc-gh-mkeller sfc-gh-mkeller enabled auto-merge (squash) July 13, 2023 21:39
@sfc-gh-mkeller sfc-gh-mkeller merged commit 7e9bdf6 into main Jul 13, 2023
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/SNOW-830394-better_changelog branch July 13, 2023 21:56
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mheavin sfc-gh-mheavin sfc-gh-mheavin approved these changes

@sfc-gh-sfan sfc-gh-sfan sfc-gh-sfan approved these changes

@sfc-gh-stan sfc-gh-stan sfc-gh-stan approved these changes

@sfc-gh-bwarsaw sfc-gh-bwarsaw Awaiting requested review from sfc-gh-bwarsaw

Assignees

@sfc-gh-mkeller sfc-gh-mkeller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-mkeller @sfc-gh-stan @sfc-gh-sfan @sfc-gh-mheavin