Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-802807 adding missing reference to config_manager.py __all__ #1603

Merged
merged 1 commit into from
Jun 16, 2023
Merged

SNOW-802807 adding missing reference to config_manager.py __all__ #1603

merged 1 commit into from
Jun 16, 2023

Conversation

sfc-gh-mkeller
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller commented Jun 16, 2023 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Complements SNOW-802807

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    It was brought to my attention that I forgot to add this one reference to config_manager.py's __all__. Correcting my mistake here.

@sfc-gh-mkeller sfc-gh-mkeller self-assigned this Jun 16, 2023
@sfc-gh-mkeller sfc-gh-mkeller added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jun 16, 2023
@sfc-gh-mkeller sfc-gh-mkeller enabled auto-merge (squash) June 16, 2023 16:38
@sfc-gh-mkeller sfc-gh-mkeller merged commit 228e8f3 into main Jun 16, 2023
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/SNOW-802807-fix_configmanager_all branch June 16, 2023 16:55
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-turbaszek sfc-gh-turbaszek Awaiting requested review from sfc-gh-turbaszek

Assignees

@sfc-gh-mkeller sfc-gh-mkeller

Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mkeller @sfc-gh-aling