Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-746341 Add file format specification to create temp stage SQL in pd_writer #1594

Merged
merged 3 commits into from
Jun 16, 2023
Merged

SNOW-746341 Add file format specification to create temp stage SQL in pd_writer #1594

merged 3 commits into from
Jun 16, 2023

Conversation

sfc-gh-stan
Copy link
Contributor

@sfc-gh-stan sfc-gh-stan commented Jun 7, 2023 •
edited by jira bot
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-746341 and enables a workaround for SNOW-735220: pd_writer example from documentation not working #1420

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    When querying staged files (nested in COPY INTO), specifying file format is required if the file is not in the default format (CSV) with default delimiters (,), unless the stage definition describes the file format.
    Reference: to https://docs.snowflake.com/en/user-guide/querying-stage#optional-parameters

@sfc-gh-stan sfc-gh-stan requested review from a team, sfc-gh-lspiegelberg, sfc-gh-vnayak and sfc-gh-hayu and removed request for a team June 7, 2023 19:53
@sfc-gh-stan sfc-gh-stan mentioned this pull request Jun 7, 2023
Closed
@sfc-gh-aalam
Copy link
Collaborator

How have we tested that this change works?

@sfc-gh-stan sfc-gh-stan added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jun 12, 2023
@sfc-gh-stan sfc-gh-stan changed the title Add file format specification to create temp stage SQL in pd_writer SNOW-746341 Add file format specification to create temp stage SQL in pd_writer Jun 12, 2023
@sfc-gh-stan sfc-gh-stan enabled auto-merge (squash) June 12, 2023 18:46
sfc-gh-aalam
sfc-gh-aalam approved these changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-aalam sfc-gh-aalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚢

@sfc-gh-stan sfc-gh-stan merged commit ea65f44 into main Jun 16, 2023
@sfc-gh-stan sfc-gh-stan deleted the Fix-pd-writer-bug branch June 16, 2023 17:25
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg Awaiting requested review from sfc-gh-lspiegelberg sfc-gh-lspiegelberg was automatically assigned from snowflakedb/snowpark-python-api

@sfc-gh-vnayak sfc-gh-vnayak Awaiting requested review from sfc-gh-vnayak sfc-gh-vnayak was automatically assigned from snowflakedb/snowpark-python-api

@sfc-gh-hayu sfc-gh-hayu Awaiting requested review from sfc-gh-hayu

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-stan @sfc-gh-aalam