Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-826794 fix mac tests #1583

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

sfc-gh-mkeller
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller commented May 26, 2023

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-826794

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Fixing Mac Jenkins tests now that they're working again. Example successful run: https://ci-dev-122.int.snowflakecomputing.com/job/RT-PyConnector38-Mac/9/console

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #1583 (a7af43c) into main (36e20a0) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1583      +/-   ##
==========================================
- Coverage   82.51%   82.35%   -0.16%     
==========================================
  Files          62       62              
  Lines        8815     8815              
  Branches     1305     1305              
==========================================
- Hits         7274     7260      -14     
- Misses       1206     1218      +12     
- Partials      335      337       +2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-mkeller sfc-gh-mkeller marked this pull request as ready for review May 26, 2023 15:47
@sfc-gh-mkeller sfc-gh-mkeller added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label May 26, 2023
@sfc-gh-mkeller sfc-gh-mkeller merged commit f2d398a into main Jun 5, 2023
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/SNOW-826794-fix_mac_tests branch June 5, 2023 20:38
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants