-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-799408: Close temp file handle before removing temp cache file #1582
SNOW-799408: Close temp file handle before removing temp cache file #1582
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1582 +/- ##
==========================================
- Coverage 82.51% 82.29% -0.23%
==========================================
Files 62 62
Lines 8815 8815
Branches 1305 1305
==========================================
- Hits 7274 7254 -20
- Misses 1206 1219 +13
- Partials 335 342 +7
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
05f4199
to
eed93b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🚢
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-799408
temp file is already an open file handle, instead of opening it again, we directly write the bytes into the file handle and then close the fd
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.