Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-802807 ConfigManager and config file support #1549

Merged
merged 28 commits into from
May 31, 2023
Merged

SNOW-802807 ConfigManager and config file support #1549

merged 28 commits into from
May 31, 2023

Conversation

sfc-gh-mkeller
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller commented May 4, 2023 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-802807

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    In this PR I add the ability for reading values out of our centralized configuration file.

@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/SNOW-765846-config_parser branch from b98034d to 378159c Compare May 5, 2023 17:37
@sfc-gh-mkeller sfc-gh-mkeller changed the title SNOW-765846 WIP: ConfigParser SNOW-765846 ConfigParser and config file support May 8, 2023
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/SNOW-765846-config_parser branch from 378159c to 78f8340 Compare May 8, 2023 23:31
@sfc-gh-mkeller sfc-gh-mkeller marked this pull request as ready for review May 8, 2023 23:54
sfc-gh-yixie
sfc-gh-yixie reviewed May 9, 2023
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
sfc-gh-jdu
sfc-gh-jdu reviewed May 10, 2023
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
src/snowflake/connector/constants.py Outdated Show resolved Hide resolved
src/snowflake/connector/config_parser/parser.py Outdated Show resolved Hide resolved
src/snowflake/connector/config_parser/parser.py Outdated Show resolved Hide resolved
src/snowflake/connector/config_parser/parser.py Outdated Show resolved Hide resolved
src/snowflake/connector/config_parser/parser.py Outdated Show resolved Hide resolved
src/snowflake/connector/config_parser/parser.py Outdated Show resolved Hide resolved
src/snowflake/connector/connection.py Show resolved Hide resolved
test/integ/test_connection.py Outdated Show resolved Hide resolved
test/integ/test_connection.py Show resolved Hide resolved
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/SNOW-765846-config_parser branch 2 times, most recently from f664fbe to 842847f Compare May 12, 2023 05:17
@sfc-gh-mkeller sfc-gh-mkeller changed the title SNOW-765846 ConfigParser and config file support SNOW-802807 ConfigParser and config file support May 12, 2023
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/SNOW-765846-config_parser branch 2 times, most recently from 846fb76 to c0351cb Compare May 16, 2023 23:00
sfc-gh-bwarsaw
sfc-gh-bwarsaw suggested changes May 17, 2023
View reviewed changes
src/snowflake/connector/config_parser/__init__.py Outdated Show resolved Hide resolved
src/snowflake/connector/config_parser/__init__.py Outdated Show resolved Hide resolved
src/snowflake/connector/config_parser/parser.py Outdated Show resolved Hide resolved
src/snowflake/connector/config_parser/parser.py Outdated Show resolved Hide resolved
src/snowflake/connector/config_parser/parser.py Outdated Show resolved Hide resolved
src/snowflake/connector/config_parser/parser.py Outdated Show resolved Hide resolved
src/snowflake/connector/config_parser/parser.py Outdated Show resolved Hide resolved
src/snowflake/connector/config_parser/parser.py Outdated Show resolved Hide resolved
src/snowflake/connector/constants.py Outdated Show resolved Hide resolved
test/integ/test_connection.py Show resolved Hide resolved
@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/SNOW-765846-config_parser branch from 0a59453 to bebef9c Compare May 25, 2023 23:58
@sfc-gh-mkeller sfc-gh-mkeller merged commit 678f09a into main May 31, 2023
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/SNOW-765846-config_parser branch May 31, 2023 00:13
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-bwarsaw sfc-gh-bwarsaw sfc-gh-bwarsaw approved these changes

@sfc-gh-jcarroll sfc-gh-jcarroll sfc-gh-jcarroll left review comments

@sfc-gh-aling sfc-gh-aling sfc-gh-aling left review comments

@sfc-gh-yixie sfc-gh-yixie sfc-gh-yixie left review comments

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg sfc-gh-lspiegelberg left review comments

@sfc-gh-jdu sfc-gh-jdu sfc-gh-jdu left review comments

@sfc-gh-hchaturvedi sfc-gh-hchaturvedi sfc-gh-hchaturvedi left review comments

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek approved these changes

@sfc-gh-stan sfc-gh-stan Awaiting requested review from sfc-gh-stan

@sfc-gh-sfan sfc-gh-sfan Awaiting requested review from sfc-gh-sfan

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sfc-gh-mkeller @sfc-gh-hchaturvedi @sfc-gh-jdu @sfc-gh-turbaszek @sfc-gh-lspiegelberg @sfc-gh-yixie @sfc-gh-aling @sfc-gh-jcarroll @sfc-gh-bwarsaw