-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-787480: fix json load encoding error #1528
SNOW-787480: fix json load encoding error #1528
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1528 +/- ##
==========================================
+ Coverage 82.10% 82.22% +0.11%
==========================================
Files 61 61
Lines 8622 8651 +29
Branches 1274 1281 +7
==========================================
+ Hits 7079 7113 +34
+ Misses 1207 1204 -3
+ Partials 336 334 -2
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small nitpicks
🚢 🚢
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-787480
next action item: add telemetry to collect encoding info: https://snowflakecomputing.atlassian.net/browse/SNOW-801885
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.