Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-787480: fix json load encoding error #1528

Merged
merged 14 commits into from
May 2, 2023

Conversation

sfc-gh-aling
Copy link
Collaborator

@sfc-gh-aling sfc-gh-aling commented Apr 24, 2023

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-787480

next action item: add telemetry to collect encoding info: https://snowflakecomputing.atlassian.net/browse/SNOW-801885

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #1528 (98fea13) into main (e937591) will increase coverage by 0.11%.
The diff coverage is 95.65%.

❗ Current head 98fea13 differs from pull request most recent head fbc8861. Consider uploading reports for the commit fbc8861 to get more accurate results

@@            Coverage Diff             @@
##             main    #1528      +/-   ##
==========================================
+ Coverage   82.10%   82.22%   +0.11%     
==========================================
  Files          61       61              
  Lines        8622     8651      +29     
  Branches     1274     1281       +7     
==========================================
+ Hits         7079     7113      +34     
+ Misses       1207     1204       -3     
+ Partials      336      334       -2     
Impacted Files Coverage Δ
src/snowflake/connector/connection.py 89.28% <ø> (ø)
src/snowflake/connector/options.py 92.45% <ø> (ø)
src/snowflake/connector/cursor.py 94.40% <84.61%> (-0.27%) ⬇️
src/snowflake/connector/auth/by_plugin.py 88.46% <100.00%> (+0.14%) ⬆️
src/snowflake/connector/file_transfer_agent.py 86.48% <100.00%> (+1.22%) ⬆️
src/snowflake/connector/network.py 82.78% <100.00%> (+0.14%) ⬆️
src/snowflake/connector/pandas_tools.py 84.11% <100.00%> (+0.45%) ⬆️
src/snowflake/connector/result_batch.py 91.95% <100.00%> (+0.23%) ⬆️
src/snowflake/connector/version.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

DESCRIPTION.md Outdated Show resolved Hide resolved
DESCRIPTION.md Outdated Show resolved Hide resolved
test/integ/test_cursor.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small nitpicks

🚢 🚢

test/integ/test_cursor.py Outdated Show resolved Hide resolved
test/integ/test_cursor.py Outdated Show resolved Hide resolved
test/integ/test_cursor.py Outdated Show resolved Hide resolved
@sfc-gh-aling sfc-gh-aling enabled auto-merge (squash) May 2, 2023 22:19
@sfc-gh-aling sfc-gh-aling merged commit 97c2599 into main May 2, 2023
@sfc-gh-aling sfc-gh-aling deleted the SNOW-787480-snowsqls-output-has-messy-code branch May 2, 2023 22:44
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants