SNOW-799216 Allow nextset without fetching result for async multistat… #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sfan
requested review from
sfc-gh-jdu,
a team and
sfc-gh-mkeller
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #1526 +/- ##
==========================================
+ Coverage 82.10% 82.17% +0.06%
==========================================
Files 61 61
Lines 8622 8638 +16
Branches 1274 1279 +5
==========================================
+ Hits 7079 7098 +19
+ Misses 1207 1206 -1
+ Partials 336 334 -2
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-mkeller
requested changes
Apr 24, 2023
| else: | ||
| assert cur.fetchall() == check | ||
| savedIds.append(cur.sfqid) | ||
| if not skip_to_last_set or index == len(checks) - 1: |
There was a problem hiding this comment.
I don't think that we should be skipping the last check
There was a problem hiding this comment.
We are not skipping the last check. We are doing the check if we are testing all sets, or if it is the last set.
…ement Description Prior to this change we are not able to call nextset before fetching result if the cursor executes an async multistatement query. The main reason is that we need to first wait the result by invoking _prefetch_hook, but in the async case, we will first call reset(), which clears the _prefetch_hook. This way _prefetch_hook will never be invoked and this causes failure in the connector. This fix adds a _prefetch_hook invoke before calling reset() Testing integ test
sfc-gh-sfan
force-pushed
the
shixuan_no_fetch
branch
from
c4d3247 to
a9b47c8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ement
Description
Prior to this change we are not able to call nextset before fetching result if the cursor executes an async multistatement query. The main reason is that we need to first wait the result by invoking _prefetch_hook, but in the async case, we will first call reset(), which clears the _prefetch_hook. This way _prefetch_hook will never be invoked and this causes failure in the connector.
This fix adds a _prefetch_hook invoke before calling reset()
Testing
integ test
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-799216
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Prior to this change we are not able to call nextset before fetching result if the cursor executes an async multistatement query. The main reason is that we need to first wait the result by invoking _prefetch_hook, but in the async case, we will first call reset(), which clears the _prefetch_hook. This way _prefetch_hook will never be invoked and this causes failure in the connector.
This fix adds a _prefetch_hook invoke before calling reset()