Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove enable_parquet_filetype param #1516

Merged
merged 2 commits into from
Apr 18, 2023
Merged

remove enable_parquet_filetype param #1516

merged 2 commits into from
Apr 18, 2023

Conversation

sfc-gh-aalam
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes broken regression tests.

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    ENABLE_PARQUET_FILETYPE param was removed here. We need to remove it from our tests to fix them.

@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Apr 18, 2023
sfc-gh-mkeller
sfc-gh-mkeller approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-aalam sfc-gh-aalam enabled auto-merge (squash) April 18, 2023 21:57
@sfc-gh-aalam sfc-gh-aalam merged commit 4ff7485 into main Apr 18, 2023
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-remove-disabled-parameter-from-test branch April 18, 2023 22:02
@thomasaarholt thomasaarholt mentioned this pull request Dec 19, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-stan sfc-gh-stan sfc-gh-stan approved these changes

@sfc-gh-mkeller sfc-gh-mkeller sfc-gh-mkeller approved these changes

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-aalam @sfc-gh-mkeller @sfc-gh-stan