Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-761669: fix memory leak in c logging #1479

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

sfc-gh-aling
Copy link
Collaborator

@sfc-gh-aling sfc-gh-aling commented Mar 16, 2023

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-761669

we have encountered the same memleak issue before: https://github.com/snowflakedb/snowflake/pull/8226/files

root cause explained: https://stackoverflow.com/questions/5508904/c-extension-in-python-return-py-buildvalue-memory-leak-problem

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #1479 (80e1be1) into main (ec95c56) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1479      +/-   ##
==========================================
- Coverage   81.91%   81.87%   -0.04%     
==========================================
  Files          60       60              
  Lines        8599     8597       -2     
  Branches     1271     1271              
==========================================
- Hits         7044     7039       -5     
  Misses       1225     1225              
- Partials      330      333       +3     
Impacted Files Coverage Δ
src/snowflake/connector/version.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great job!

🚢 🚢

@sfc-gh-aling sfc-gh-aling merged commit 9008e2c into main Mar 17, 2023
@sfc-gh-aling sfc-gh-aling deleted the SNOW-761669-fix-memory-leak-in-c-logging branch March 17, 2023 16:49
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants