Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keypair.py #1440

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Update keypair.py #1440

merged 1 commit into from
Feb 23, 2023

Conversation

emilhe
Copy link
Contributor

@emilhe emilhe commented Feb 15, 2023

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-744534: prepare() gets args, but supports only kwargs #1439

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    The error occurs because the prepare function expect user/account arguments to be keyword arguments, but they are passed as positional argument. This PR fixes the issue by passing them as keyword arguments instead.

Pass account/user as kwargs (instead of args) to 'self.prepare'.
@github-actions
Copy link

github-actions bot commented Feb 15, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@emilhe
Copy link
Contributor Author

emilhe commented Feb 15, 2023

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-aling
Copy link
Collaborator

accompanying PR for testing: #1442

@sfc-gh-aling sfc-gh-aling merged commit 97de8e6 into snowflakedb:main Feb 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-744534: prepare() gets args, but supports only kwargs
3 participants