Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-743465: fix snowcli test failure by reverting test util change #1438

Conversation

sfc-gh-aling
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@codecov-commenter
Copy link

Codecov Report

Merging #1438 (31b5edc) into main (1d3d87e) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1438      +/-   ##
==========================================
- Coverage   81.77%   81.71%   -0.06%     
==========================================
  Files          60       60              
  Lines        8575     8576       +1     
  Branches     1266     1266              
==========================================
- Hits         7012     7008       -4     
- Misses       1236     1241       +5     
  Partials      327      327              
Impacted Files Coverage Δ
src/snowflake/connector/test_util.py 56.25% <100.00%> (+2.91%) ⬆️
src/snowflake/connector/ocsp_asn1crypto.py 79.09% <0.00%> (-1.37%) ⬇️
src/snowflake/connector/errors.py 89.89% <0.00%> (-0.54%) ⬇️
src/snowflake/connector/ocsp_snowflake.py 77.05% <0.00%> (-0.27%) ⬇️
src/snowflake/connector/cache.py 87.95% <0.00%> (+0.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-aling sfc-gh-aling merged commit 10f7940 into main Feb 14, 2023
@sfc-gh-aling sfc-gh-aling deleted the SNOW-743465-connector-fix-snowsql-test-failure-due-to-mypy-import branch February 14, 2023 22:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants