SNOW-730503: pip install awscli in windows build script #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1410 +/- ##
==========================================
- Coverage 81.47% 81.42% -0.06%
==========================================
Files 61 61
Lines 8558 8558
Branches 1263 1263
==========================================
- Hits 6973 6968 -5
- Misses 1257 1263 +6
+ Partials 328 327 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-aalam
requested review from
a team and
sfc-gh-stan
and removed request for
a team
sfc-gh-sfan
reviewed
Jan 23, 2023
sfc-gh-aalam
commented
Jan 24, 2023
remove redundant install
Good point. Should have noticed it myself. Now removed |
sfc-gh-sfan
approved these changes
Jan 24, 2023
ci/build_windows.bat
Outdated
| @@ -22,6 +22,9 @@ if %errorlevel% neq 0 goto :error | |||
| python -m pip install --upgrade pip setuptools wheel | |||
| if %errorlevel% neq 0 goto :error | |||
|
|
|||
| pip install --upgrade --user awscli | |||
There was a problem hiding this comment.
Can this be inlined with line 22? Given you also use --user here, maybe it's not possible.
There was a problem hiding this comment.
yep. Just did that. Hopefully it should work, otherwise we can do a --user
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #SNOW-730503
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.