Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Lint #1408

Merged
merged 2 commits into from
Jan 21, 2023
Merged

Fix Lint #1408

merged 2 commits into from
Jan 21, 2023

Conversation

sfc-gh-aalam
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Fix lint error

@sfc-gh-aalam sfc-gh-aalam requested review from a team, sfc-gh-lspiegelberg, sfc-gh-achandrasekaran and sfc-gh-mkeller and removed request for a team January 21, 2023 00:14
@sfc-gh-aalam sfc-gh-aalam changed the title Fix Link Fix Lint Jan 21, 2023
sfc-gh-mkeller
sfc-gh-mkeller approved these changes Jan 21, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-aalam sfc-gh-aalam enabled auto-merge (squash) January 21, 2023 00:20
@sfc-gh-aalam sfc-gh-aalam merged commit f420c26 into main Jan 21, 2023
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-put_get_lint_fix branch January 21, 2023 00:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mkeller sfc-gh-mkeller sfc-gh-mkeller approved these changes

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg Awaiting requested review from sfc-gh-lspiegelberg sfc-gh-lspiegelberg was automatically assigned from snowflakedb/snowpark-python-api

@sfc-gh-achandrasekaran sfc-gh-achandrasekaran Awaiting requested review from sfc-gh-achandrasekaran sfc-gh-achandrasekaran was automatically assigned from snowflakedb/snowpark-python-api

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-aalam @sfc-gh-mkeller