SNOW-698526: Python connector 2.8.2 infinite loop in OCSP cache validation #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 23, 2022
This was referenced Nov 23, 2022
Codecov Report
@@ Coverage Diff @@
## main #1348 +/- ##
==========================================
- Coverage 82.39% 82.07% -0.32%
==========================================
Files 60 60
Lines 8424 8425 +1
Branches 1248 1248
==========================================
- Hits 6941 6915 -26
- Misses 1174 1202 +28
+ Partials 309 308 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was
unlinked from
issues
Nov 23, 2022
sfc-gh-aling
deleted the
SNOW-698526-python-connector-2-8-2-infinite-loop-in-ocsp-cache-validation
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-698526
_getitemshould not be overwritten in SFDictFileCache as_getitemis used by load to clean up in-memory expired cache. To resolve the issue, introduce a new non-locking get method in SFDictFileCache to segregate the functionalityFill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.