-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-676736: get file results in change of file permissions does not inherit parent folder permission #1338
Merged
sfc-gh-aling
merged 6 commits into
main
from
SNOW-676736-get-file-results-in-change-of-file-permissions-does-not-inherit-parent-folder-permission
Nov 22, 2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le-permissions-does-not-inherit-parent-folder-permission
Codecov Report
@@ Coverage Diff @@
## main #1338 +/- ##
==========================================
- Coverage 82.32% 82.19% -0.14%
==========================================
Files 60 60
Lines 8421 8424 +3
Branches 1247 1248 +1
==========================================
- Hits 6933 6924 -9
- Misses 1179 1189 +10
- Partials 309 311 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-mkeller
requested changes
Nov 21, 2022
sfc-gh-aling
commented
Nov 22, 2022
sfc-gh-aling
commented
Nov 22, 2022
sfc-gh-mkeller
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🚢
sfc-gh-aling
deleted the
SNOW-676736-get-file-results-in-change-of-file-permissions-does-not-inherit-parent-folder-permission
branch
November 22, 2022 22:33
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #SNOW-676736
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
mkstemp creates a temporary file in the most secure manner possible -- which is only given permission to the current user, not to
group
orother
which is not expected.change to use
open
which will inherit the default file permission.