-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-686222: Remove os.path.realpath in storage_client.py #1326
Conversation
e5bb07f
to
b6245a4
Compare
tox.ini
Outdated
@@ -181,7 +181,7 @@ known_first_party =snowflake,parameters,generate_test_files | |||
[flake8] | |||
# Notes on ignores: | |||
# - all ignored Ds mean doc issues, these should be cleaned up | |||
ignore = B011,C901,D100,D101,D102,D103,D104,D105,D107,D401,E203,E402,E501,F821,W503 | |||
ignore = B011,B027,C901,D100,D101,D102,D103,D104,D105,D107,D401,E203,E402,E501,F821,W503 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for
snowflake-connector-python/src/snowflake/connector/storage_client.py
Lines 419 to 431 in b6245a4
def _update_presigned_url(self) -> None: | |
pass | |
# Override in S3 | |
def _initiate_multipart_upload(self) -> None: | |
pass | |
# Override in S3 | |
def _complete_multipart_upload(self) -> None: | |
pass | |
# Override in S3 | |
def _abort_multipart_upload(self) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of ignoring this issue in the whole project, could we add comments on these definitions to ignore this error for only these functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed pass
to return
. I did try to add #noqa
to ignore the flake8 violation, but yesqa keeps remove #noqa
saying it's unnesscary 🤦 and I couldn't find a way to add #noqa
here for this function...
b6245a4
to
e7f1b6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These classes could use a V2 sometime soon :)
🚢 🚢
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-686222
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.