SNOW-535152 Updated regex to also include the old error code #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/integ/test_errors.py
Outdated
| @@ -40,7 +40,9 @@ def test_error_code(conn_cnx): | |||
| e.value.sqlstate == syntax_sqlstate | |||
| or e.value.sqlstate == syntax_sqlstate_old | |||
| ), "Syntax SQL state" | |||
| e.match(rf"^{syntax_errno:06d} \({syntax_sqlstate}\): ") | |||
| e.match( | |||
| rf"^({syntax_errno:06d}|{syntax_errno_old:06d}) \(({syntax_sqlstate}|{syntax_sqlstate_old})\): " | |||
There was a problem hiding this comment.
Technically this would be more precise:
Suggested change
| rf"^({syntax_errno:06d}|{syntax_errno_old:06d}) \(({syntax_sqlstate}|{syntax_sqlstate_old})\): " | |
| rf"^({syntax_errno_old:06d} \({syntax_sqlstate_old}\)|{syntax_errno:06d} \({syntax_sqlstate}\)): ": |
Codecov Report
@@ Coverage Diff @@
## main #1298 +/- ##
==========================================
+ Coverage 81.49% 81.52% +0.02%
==========================================
Files 59 59
Lines 8562 8562
Branches 1275 1275
==========================================
+ Hits 6978 6980 +2
+ Misses 1277 1275 -2
Partials 307 307
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-mkeller
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes broken test from 1297
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Forgot to update regex, regex is now updated