-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-642635: Remove legacy ocsp cache code #1292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1292 +/- ##
==========================================
+ Coverage 81.49% 82.07% +0.57%
==========================================
Files 59 59
Lines 8562 8386 -176
Branches 1275 1240 -35
==========================================
- Hits 6978 6883 -95
+ Misses 1277 1196 -81
Partials 307 307
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-mkeller
requested changes
Oct 31, 2022
sfc-gh-aling
force-pushed
the
SNOW-642635-remove-legacy-ocsp-cache-code
branch
from
November 1, 2022 21:05
1f6429c
to
7438a27
Compare
sfc-gh-aling
force-pushed
the
SNOW-642635-remove-legacy-ocsp-cache-code
branch
from
November 1, 2022 21:08
7438a27
to
fcd4786
Compare
sfc-gh-mkeller
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🚢
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #SNOW-642635
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.