SNOW-651560: Fix the metadata issue when extTypeName from the returned json result is empty
#1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jdu
requested review from
sfc-gh-mkeller and
sfc-gh-kwagner
as code owners
sfc-gh-jdu
commented
Aug 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #1239 +/- ##
==========================================
+ Coverage 81.68% 81.75% +0.07%
==========================================
Files 59 59
Lines 8503 8503
Branches 1378 1378
==========================================
+ Hits 6946 6952 +6
+ Misses 1248 1242 -6
Partials 309 309
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-sfan
approved these changes
Aug 25, 2022
Yes |
sfc-gh-kwagner
approved these changes
Aug 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-651560
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
extTypeNamecan exist in the returned json result but it can be empty when it's returned from table stored proc. See the jira for more details and the code path. After it's merged, I will update the SP connector as well.