-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-644849: Add telemetry about imported pacakages at runtime #1236
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1236 +/- ##
==========================================
+ Coverage 81.63% 81.65% +0.01%
==========================================
Files 59 59
Lines 8522 8531 +9
Branches 1379 1382 +3
==========================================
+ Hits 6957 6966 +9
- Misses 1258 1259 +1
+ Partials 307 306 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I kinda agree this is a little bit too hacky...(scratched my comment about sp as I thought this is snowpark by mistake). |
It will not work in SP (similar to snowflakedb/snowpark-python#274), and I don't expect it works in SP because per our discussion, we can just collect pakcages information of a SP from snowhouse. Though it's pretty hacky, it still works (you can find in the test) and I'm just looking for a better way to do that... |
73aed53
to
84e7c3d
Compare
I changed to use |
8599c63
to
acca9f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🚢
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
SNOW-644849
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
We would like to know what packages are imported at Python runtime along with connector, which can help us understand the user scenarios of python connector. The message will looks like this: